Add a whole-file/program parser to twill-parser #45

New issue

Closed

opened 2026-08-20 20:00:03 +00:00 by jacksonopp · 0 comments

jacksonopp commented

2026-08-20 20:00:03 +00:00

Owner

Discovered while working through #44 (db trait + SourceFile skeleton): twill-check's parse tracked fn needs to hand a whole file's text to twill-parser and get back a full module/program, not a single statement, so this blocks #43 (lowering the parsed AST) from doing anything real.

Scope: a program_parser (name TBD) that repeats stmt_parser() to end-of-input, returning something like Vec<Spanned<Stmt<'src>>> or a dedicated Program/Module AST node -- same one-fn-per-production, .boxed() convention as the rest of parser.rs. Snapshot-test it the same way other productions are tested.

twill-parser has no entry point that parses a whole source file. stmt_parser() parses exactly one statement, and every call site (including all existing tests) only ever calls it once -- there's no repeated()-style production that consumes a sequence of top-level statements until EOF. Discovered while working through #44 (db trait + SourceFile skeleton): twill-check's parse tracked fn needs to hand a whole file's text to twill-parser and get back a full module/program, not a single statement, so this blocks #43 (lowering the parsed AST) from doing anything real. Scope: a program_parser (name TBD) that repeats stmt_parser() to end-of-input, returning something like Vec<Spanned<Stmt<'src>>> or a dedicated Program/Module AST node -- same one-fn-per-production, .boxed() convention as the rest of parser.rs. Snapshot-test it the same way other productions are tested.

jacksonopp added this to the Step 2: Core Type Checker milestone

2026-08-20 20:00:03 +00:00

jacksonopp added the

user-story

label

2026-08-20 20:00:03 +00:00

jacksonopp referenced this issue from a pull request that will close it,

2026-08-20 22:14:08 +00:00

Checker crate skeleton: salsa db, SourceFile input, whole-file parser #46

jacksonopp closed this issue

2026-08-21 15:38:51 +00:00